Major Refactor - Faster, Robust Data Schemas #195
Conversation
|
different NWP provider, need to check
Forecasts
|
|
Add github issue for unit tests for provider test files |
| @@ -0,0 +1,501 @@ | |||
| """Domain classes for store metadata. | |||
|
|
|||
There was a problem hiding this comment.
think of renaming ....
devsjc
changed the title
| "the area of the grid square covered by any cloud " | ||
| "to the square's total area.", | ||
| units="UI", | ||
| limits=ParameterLimits(upper=1, lower=0), |
There was a problem hiding this comment.
are any in percentage? i thnk ive seen cloud cover go from 0-100 before, but perhaps you've convered this
| """ | ||
| store_range: str = coords.init_time[0].strftime("%Y%m%d%H") | ||
| if len(coords.init_time) > 1: | ||
| store_range = f"{coords.init_time[0]:%Y%m%d%H}-{coords.init_time[-1]:%Y%m%d%H}" |
There was a problem hiding this comment.
could you do store_range+=f"-{coords.init_time[-1]:%Y%m%d%H}" to shortened the code
| @@ -0,0 +1,17 @@ | |||
| """Model Repositories | |||
|
|
|||
| TODO: Add description | |||
| @@ -0,0 +1,148 @@ | |||
| """Implementation of the NWP consumer services.""" | |||
There was a problem hiding this comment.
Is it worht saying, this is for collecting live NWPs?
| self.nr = notification_repository | ||
|
|
||
| @override | ||
| def consume(self, it: dt.datetime | None = None) -> ResultE[str]: |
| np.arange(45, 135, 0.234), | ||
| np.arange(135, 225, 0.234), | ||
| np.arange(225, 315, 0.234), | ||
| ]) |
There was a problem hiding this comment.
could these be moved out to the top of this file?
| Args: | ||
| filename: The name of the file. | ||
| it: The init time of the model run. | ||
| max_step: The maximum step in hours to consider. |
There was a problem hiding this comment.
I wonder if it in general should change to init_time, not to many more characters and its slightly easier to read
|
|
||
| Data is provided on a per-order basis, so the filestructure depends on the order ID. | ||
| For OCF's purposes, on file per parameter per step is requested. | ||
|
|
There was a problem hiding this comment.
weoth mentioning env vars up here?
Modifies the core logic to be focussed around the downloading of a single int time as quickly as possible, processing required files in parallel.
Highlights:
This introduces many breaking changes to prior usage: